Load dyld manually with 'main bin spec' userland corefiles #4124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ProcessMachCore::DoLoadCore when we have a standalone binary and a 'main bin spec' LC_NOTE detailing the UUID and load address, ProcessMachCore will do a (potentially slow) lookup to try to find the binary and/or dSYM. For kernel and userland corefile using 'main bin spec', we would follow the normal schemes of locating them. DynamicLoaderDarwinKernel would use the same (possibly expensive) calls to find the correct binary. dyld by default would use the in-core-file binary image, and so if the corefile didn't include the entire address space, the LINKEDIT for dyld could be missing. This means we can't find the dyld4::dyld_all_image_infos struct, which tells us where the other binaries are loaded in memory. Treat userland 'bin main spec' like we do standalone firmewares; try the expensive checks to find the best dyld we can, before falling back to using a memory module out of the corefile. Also add a little TODO for myself in this load_standalone_binary function that we should handle the case of a binary in the shared cache correctly, creating a memory module in the corefile and using the segment load addresses from that to set our segment load addresses for the final binary. rdar://89717101 (cherry picked from commit 9a8a0a3)
|
@swit-ci please test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
jasonmolenda
deleted the
r89717101-do-expensive-searches-for-dyld-in-userland-corefile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load dyld manually with 'main bin spec' userland corefiles
In ProcessMachCore::DoLoadCore when we have a standalone
binary and a 'main bin spec' LC_NOTE detailing the UUID and
load address, ProcessMachCore will do a (potentially slow)
lookup to try to find the binary and/or dSYM. For kernel and
userland corefile using 'main bin spec', we would follow the
normal schemes of locating them. DynamicLoaderDarwinKernel would
use the same (possibly expensive) calls to find the correct
binary. dyld by default would use the in-core-file binary image,
and so if the corefile didn't include the entire address space,
the LINKEDIT for dyld could be missing. This means we can't find
the dyld4::dyld_all_image_infos struct, which tells us where the
other binaries are loaded in memory.
Treat userland 'bin main spec' like we do standalone firmewares;
try the expensive checks to find the best dyld we can, before
falling back to using a memory module out of the corefile.
Also add a little TODO for myself in this load_standalone_binary
function that we should handle the case of a binary in the shared
cache correctly, creating a memory module in the corefile and
using the segment load addresses from that to set our segment
load addresses for the final binary.
rdar://89717101
(cherry picked from commit 9a8a0a3)