🍒/5.7/af2ea183f5e3+257f98466222+66b829ac7b68 #4197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDevlieghere
commented
Apr 8, 2022
JDevlieghere
commented
- [lldb] Import Foundation in TestConflictingDefinition.py
- [lldb] Fix TestQuoting when run remotely
- [lldb] Skip a bunch of tests that shouldn't run remotely
We need to import foundation to get a 'NSLog' declaration when building against the iOS SDK. This doesn't appear necessary when building against the macOS SDK, presumable because it gets transitively imported by objc/NSObject.h (cherry picked from commit af2ea18)
(cherry picked from commit 257f984)
Skip a bunch of tests that don't really make sense to run remotely. (cherry picked from commit 66b829a)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.