🍒/5.7/59679eeef2d471dc0c2bccb966aac5eae9195802+833882b32701ce3713c9dd9afdedf1126db691f0 #4202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDevlieghere
commented
Apr 9, 2022
JDevlieghere
commented
- Use true/false instead of 1/0 (NFC)
- Adapt the ObjC stepping algorithm to deal with "selector-stubs" in clang.
Identified by modernize-use-bool-literals. (cherry picked from commit 8afcfbf) (cherry picked from commit 59679eeef2d471dc0c2bccb966aac5eae9195802)
…ang. Clang is adding a feature to ObjC code generation, where instead of calling objc_msgSend directly with an object & selector, it generates a stub that gets passed only the object and the stub figures out the selector. This patch adds support for following that dispatch method into the implementation function. (cherry picked from commit 833882b)
|
@swift-ci please test |
JDevlieghere
deleted the
🍒/5.7/59679eeef2d471dc0c2bccb966aac5eae9195802+833882b32701ce3713c9dd9afdedf1126db691f0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.