Support hermetic index store data via path remappings #4207 #4267
Conversation
|
Same comment as the previous PR, ie. it'd be nice to extract the map into its own type. Otherwise LGTM. I've started the tests on the swift branch, though it will need to be updated as well as there's a conflict now. |
DavidGoldman
force-pushed
the
stable/20211026
branch
from
e3b6e05 to
8d36b46
Compare
|
PTAL |
|
@swift-ci please test |
|
How is this looking - can we test this here or does it need to be on the Swift PR? |
|
Can test here as well, Swift PR would just test more is all. Could you clean up the commits in a rebase and then I'll run the tests? EDIT: Actually, this changes API that Swift uses - so we should make sure it's passing before we merge. And also merge both close to each other to avoid spurious failures. |
|
Yeah will do, I'm just having issues building swift at all now, need to figure out why it's broken even without my changes |
- When indexing, `-fdebug-prefix-map` will be used to remap paths so the computed index data will be hermetic. This includes the unit files' names as well as all paths embedded in the unit files. - When reading, a reverse mapping can be used e.g. via `indexstore_store_create_with_options` to automatically remap the hermetic index data to the correct local paths.
DavidGoldman
force-pushed
the
stable/20211026
branch
from
52e3807 to
80f559e
Compare
|
Squashed and rebased here |
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
When indexing,
-fdebug-prefix-mapwill be used to remappaths so the computed index data will be hermetic. This
includes the unit files' names as well as all paths embedded
in the unit files.
When reading, a reverse mapping can be used e.g. via
indexstore_store_create_with_optionsto automaticallyremap the hermetic index data to the correct local paths.
Same as #4207 but against
stable/20211024instead ofapple:next