[stable/20220421] SymbolGraph ExtractAPI support for C and Objective-C in clang #4453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix one test (enum.c) in ExtractAPI to use %clang_cc1 and -verify instead of calling the full driver and FileCheck. This is an example for my comment from https://reviews.llvm.org/D121873. Differential Revision: https://reviews.llvm.org/D124634
This patch transforms the given input headers to relative include names using header search entries and some heuritics. For example: `/Path/To/Header.h` will be included as `<Header.h>` with a search path of `-I /Path/To/`; and `/Path/To/Framework.framework/Headers/Header.h` will be included as `<Framework/Header.h>`, given a search path of `-F /Path/To`. Headermaps will also be queried in reverse to find a spelled name to include headers. Differential Revision: https://reviews.llvm.org/D123831
4c262fe accidentally added local unfinished test case clang/test/Index/annotate-comments-enum-constant.c This patch removes it.
This reverts commit 4c262fe. Revert to fix Msan and Asan errors.
Reapply the change after fixing sanitizer errors. The original problem was that `StringRef`s in `Matches` are pointing to temporary local `std::string`s created by `path::convert_to_slash` in the regex match call. This patch does the conversion up front in container `FilePath`. This reverts commit 2966f0f. Differential Revision: https://reviews.llvm.org/D124964
Differential Revision: https://reviews.llvm.org/D124995
daniel-grumberg
requested review from
tkremenek,
airspeedswift,
zixu-w and
ributzka
|
@swift-ci please test |
daniel-grumberg
changed the title
|
Testing won't work on this branch, if it passes in stable/20211026 I'm happy to merge it. |
bnbarham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to introduce here the same functionality as in #4442