Merge format string attribute changes to apple/llvm-project #4736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [[format_arg(N)]] tells Clang that a method returns a format string with specifiers equivalent to those passed in the string at argument #N. It obviously requires the argument and the return type to be strings both. - `instancetype` is a special return type available in Objective-C class definitions that Clang expands to the most-derived statically known type on use. - In Objective-C mode, NSString is allowed in lieu of a C string, both as input and output. However, _in the definition of NSString_, Clang rejects format_arg on methods that return NSString. This PR addresses this issue by substituting `instancetype` with the enclosing definition's type during the validation of `format_arg`. Reviewed By: ahatanak Differential Revision: https://reviews.llvm.org/D112670 Radar-Id: rdar://84729746
* The format_arg attribute tells the compiler that the attributed function returns a format string that is compatible with a format string that is being passed as a specific argument. * Several NSString methods return copies of their input, so they would ideally have the format_arg attribute. A previous differential (D112670) added support for instancetype methods having the format_arg attribute when used in the context of NSString method declarations. * D112670 failed to account that instancetype can be sugared in certain narrow (but critical) scenarios, like by using nullability specifiers. This patch resolves this problem. Differential Revision: https://reviews.llvm.org/D113636 Reviewed By: ahatanak Radar-Id: rdar://85278860
|
@swift-ci test |
DougGregor
approved these changes
May 24, 2022
hyp
approved these changes
May 24, 2022
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks 2 commits from the main LLVM monorepo to the swift/release/5.7 branch:
Radar-Id: rdar://93860676