[5.7][Index/IndexStore] Preserve the canonical output file path #4766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, make sure we don't accidentally convert the output file path to the local equivalent when computing the unit name in IndexStore, as that will accidentally treat it as a different unit.
DavidGoldman
changed the title
|
@swift-ci please test |
|
@swift-ci please test |
bnbarham
approved these changes
May 31, 2022
akyrtzi
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, make sure we don't accidentally convert the output file
path to the local equivalent when computing the unit name in IndexStore,
as that will accidentally treat it as a different unit.
This fix is critical to get IndexStore-DB working with path remappings, in particular with the explicit unit output paths case.