[lldb/Swift] Add progress report callback when loading a module #4773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires apple:swift/59181 |
medismailben
force-pushed
the
module-loading-callbacks
branch
2 times, most recently
from
051cbb4 to
b57cd31
Compare
medismailben
force-pushed
the
module-loading-callbacks
branch
from
b57cd31 to
678fc19
Compare
adrian-prantl
approved these changes
Jun 8, 2022
medismailben
force-pushed
the
module-loading-callbacks
branch
2 times, most recently
from
7002416 to
e779691
Compare
This patch introduces a new ReportModuleLoadingProgress callback that gets invoked by the Swift AST Context when loading new modules and module overlays. This patch also updates TestSwiftProgressReporting to check that these new progress reports are broadcasted correctly. rdar://94165195 Signed-off-by: Med Ismail Bennani <[email protected]>
medismailben
force-pushed
the
module-loading-callbacks
branch
from
e779691 to
4aadd73
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a new
ReportModuleLoadingProgresscallback thatgets invoked by the Swift AST Context when loading new modules and
module overlays.
This patch also updates
TestSwiftProgressReportingto check that thesenew progress reports are broadcasted correctly.
rdar://94165195
Signed-off-by: Med Ismail Bennani [email protected]