Skip to content

[release/5.7][move-function] Cherry-pick LLVM changes needed for _move in 5.7 #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link

Just adding remaining changes.

gottesmm added 4 commits May 31, 2022 13:11
…ebug variable.

Otherwise, we may hoist a llvm.dbg.addr over another llvm.dbg.addr or
llvm.dbg.value, changing observable debugging state.

As an additional benefit, this finally lets me add straight line end to end lldb
tests for async var and lets. This was the last thing stopping me from doing that.
…to the current function from parent function when evaluating subexpressions.

This occurs when the parent function does not have debug info (*). In swift async
functions this is ok since we only need to be able to restore the ABI defined
context register for the async context (r14)... so it is not necessary to match
with a callsite parameter.

(*) E.x.: On Linux async funclets called from a libswift_Concurrency.so that had its
debug info stripped.
@gottesmm gottesmm requested a review from adrian-prantl May 31, 2022 21:14
@gottesmm
Copy link
Author

@swift-ci test

@gottesmm
Copy link
Author

gottesmm commented Jun 1, 2022

swiftlang/swift#59184

@swift-ci test macOS platform

@gottesmm gottesmm merged commit f236856 into swiftlang:swift/release/5.7 Jun 2, 2022
@gottesmm gottesmm deleted the swift/release/5.7-movedbginfo branch June 2, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants