[5.7][lldb] Look through existential types when handling typealiases in SwiftASTContext to correctly handle AnyObject existentials.
#4863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
adrian-prantl
approved these changes
Jun 23, 2022
hborla
force-pushed
the
5.7-lldb-existential-any-anyobject
branch
from
0cacfc6 to
adedc74
Compare
|
@swift-ci please test |
SwiftASTContext to correctly handle AnyObject existentials.
hborla
force-pushed
the
5.7-lldb-existential-any-anyobject
branch
from
adedc74 to
ccb4a75
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #4852, against the right branch this time 🙂
swiftlang/swift#59657 updates the representation of Any and AnyObject in the Swift frontend to use
ExistentialType. Typealiases likeAnyObjectcan be used as existential types, which are represented asExistentialType(TypeAliasType), so LLDB should look through to an existential type's constraint when checking whether it has a typealias.