Hardcode that the Swift.AnyObject typealias resolves to the builtin A… #4882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
augusto2112
approved these changes
Jun 24, 2022
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
| if (!module || !module->hasText() || module->getText() != swift::STDLIB_NAME) | ||
| return false; | ||
| NodePointer ident = node->getChild(1); | ||
| if (!ident || !ident->hasText() || ident->getText() != "AnyObject") |
There was a problem hiding this comment.
Nit, you could replace these two lines with:
return ident && ident->hasText() && ident->getText() == "AnyObject";
There was a problem hiding this comment.
I didn't want to make it harder to read by suddenly inverting the conditions on the last line.
|
@swift-ci test macOS |
…nyObject type. This prevents round-tripping to SwiftASTContext to resolve these types.
adrian-prantl
force-pushed
the
hardcode-anyobject
branch
from
c2d30d2 to
e4dd934
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcode that the Swift.AnyObject typealias resolves to the builtin A…
…nyObject type.
This prevents round-tripping to SwiftASTContext to resolve these types.