[lldb] TSSTypeRef::GetBitSize fallback to SASTContext if runtime fails #4914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usual strategy of TypeSystemSwiftTypeRef functions is to fallback to SwiftASTContext in case it fails, make GetBitSize follow that pattern. Also, always log that failure even in the case of types defined in the expression, as we've been recovering information for those types for a while now. rdar://96166383
|
@swift-ci test |
kastiglione
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usual strategy of TypeSystemSwiftTypeRef functions is to fallback to
SwiftASTContext in case it fails, make GetBitSize follow that pattern.
Also, always log that failure even in the case of types defined in the
expression, as we've been recovering information for those types for a
while now.
rdar://96166383