Skip to content

[lldb] Handle unsupported type in GetPointerType #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link

@kastiglione kastiglione commented Jul 15, 2022

For TypeSystemSwiftTypeRef::GetPointerType to succeed, the given type variable first must be demangled. If that fails, the function must return an empty CompilerType.

This fixes downstream crashes in GetPointerTo where Node::addChild is called, but with a null node. This causes an abort in addChild, where the child node is required to be non-null.

rdar://96170947
(cherry-picked from commit 21d1b51)

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione kastiglione merged commit 2b846a4 into stable/20220421 Jul 15, 2022
@kastiglione kastiglione deleted the lldb-Handle-unsupported-type-in-GetPointerType-4954-stable-20220421 branch July 15, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant