[lldb] Restore missing call to ThreadPlanStack::SetTID #4996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
kastiglione
deleted the
lldb-Restore-deleted-call-to-ThreadPlanStackMap-SetTID-stable-20220421
branch
kastiglione
added a commit
that referenced
this pull request
Jul 19, 2022
This call to `ThreadPlanStack::SetTID` seems to have been unintentionally deleted in #3172. This call sets the TID of all thread plans in the stack, and must be called before calling `Activate`. This resulted in downstream misbehavior, one example of which is in `ThreadPlanStackMap::Update` where a base plan was being queued multiple times on to the same plan stack because the TID wasn't correct. https://github.com/apple/llvm-project/blob/be3823b722c461f7c11f81601e33a3e53ea76565/lldb/source/Target/ThreadPlanStack.cpp#L418-L422 rdar://96534399 (cherry-picked from commit 24f4737) (cherry-picked from commit 3348866)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This call to
ThreadPlanStack::SetTIDseems to have been unintentionally deleted in #3172. This call sets the TID of all thread plans in the stack, and must be called before callingActivate.This resulted in downstream misbehavior, one example of which is in
ThreadPlanStackMap::Updatewhere a base plan was being queued multiple times on to the same plan stack because the TID wasn't correct.https://github.com/apple/llvm-project/blob/be3823b722c461f7c11f81601e33a3e53ea76565/lldb/source/Target/ThreadPlanStack.cpp#L418-L422
rdar://96534399
(cherry-picked from commit 24f4737)