[apinotes][cxx-interop] Add support for namespaces, nested tags, and methods. #5022
Conversation
|
@swift-ci please smoke test |
clang/test/APINotes/Inputs/Frameworks/CXXInteropKit.framework/Headers/CXXInteropKit.apinotes
Outdated
Show resolved
Hide resolved
| // CHECK-FN: SwiftNameAttr {{.+}} <<invalid sloc>> "childFnInNS()" | ||
|
|
||
| // CHECK-REF: Dumping ImportAsReference: | ||
| // CHECK-REF: SwiftAttrAttr {{.+}} <<invalid sloc>> Implicit "import_reference" |
There was a problem hiding this comment.
Nit: It would be better if you could have a separate test case file for the new import_as , retain and release attributes.
There was a problem hiding this comment.
It's a fairly small test file, I'd like to keep it all together as it's testing roughly the same thing.
There was a problem hiding this comment.
If you feel strongly, I will fix it post-commit.
|
Your patch has no testing for the Bitcode serialization changes, that should be tested to ensure it works. |
These are emitted with the module, so it's tested as part of the end-to-end test I have. |
|
Thanks for the review, Alex! |
|
@swift-ci Please Build Toolchain macOS Platform |
|
It looks like this change introduces huge compile-time regressions when building C++ projects with clang. For example, when building The regression can also be reproduced when building Could you please take a look and revert the changes if it isn't a trivial fix, as this is impacting our CI quite a bit. |
|
I was able to track down the biggest increase to 8e7ea0c |
Refs: #5021