Sink SwiftHost.cpp into HostInfo (NFC) #5165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
force-pushed
the
92640609
branch
2 times, most recently
from
825d9d1 to
1a98aea
Compare
adrian-prantl
requested review from
kastiglione,
JDevlieghere,
augusto2112 and
compnerd
|
@swift-ci test |
JDevlieghere
approved these changes
Aug 20, 2022
compnerd
reviewed
Aug 20, 2022
This refactors the code that currently lives in Expression/SwiftHost to find a new home in HostInfo. The idea is to eventually allow different implementations per host platform. Note that this is intentionally just moving the code around, there has been no attempt at cleaning up the code or interface. rdar://92640609
adrian-prantl
force-pushed
the
92640609
branch
from
1a98aea to
81be9ba
Compare
Thanks @compnerd, you are right, HostInfoWindows does not inherit from HostInfoPosix. So I made the patch even more complex, by moving the shared functionality into |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the code that currently lives in Expression/SwiftHost
to find a new home in HostInfo. The idea is to eventually allow
different implementations per host platform. Note that this is
intentionally just moving the code around, there has been no attempt
at cleaning up the code or interface.
rdar://92640609