Restore the per-module scratch context fallback mechanism. #5308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the copy constructor is called m_readers needs to be incremented because the destructor will be calkled on both the original object and the copy.
so it can (in a follow-up commit) be initialized with the current frame as ExecutionContextScope. NFC
This feature has been accidentally disabled when introducing TypeSystemSwiftTypeRefForExpressions and thanks to how good TypeSystemSwiftTypeRef has become, all of the tests for the feature were still passing.
|
@swift-ci test |
|
ping |
augusto2112
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature has been accidentally disabled when introducing
TypeSystemSwiftTypeRefForExpressions and thanks to how good
TypeSystemSwiftTypeRef has become, all of the tests for the feature
were still passing.