[lldb] Add Substring type summary #5559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test |
augusto2112
approved these changes
Nov 7, 2022
|
@swift-ci test |
Michael137
reviewed
Nov 14, 2022
| uint64_t buffer[2] = {raw0, raw1}; | ||
| uint64_t rawBuffer[2] = {raw0, raw1}; | ||
| auto *buffer = (uint8_t *)&rawBuffer; | ||
| applySlice(buffer, count, slice); |
There was a problem hiding this comment.
Correct me if I'm wrong but AFAIU this is technically UB. I don't think any compiler will break this kind of type punning but the recommended way of reading a type through a uint8_t* is using memcpy.
The standard doesn't technically permit doing pointer arithmetic on something that isn't pointer-interconvertible. Chances are memcpy will get optimised away into exactly the same code that reinterpret_cast produces because memcpy is compiler magic.
kastiglione
added a commit
that referenced
this pull request
Nov 17, 2022
Replace hex literals with binary literals to improve bit masking readability. Follow up to #5559.
kastiglione
added a commit
that referenced
this pull request
Dec 3, 2022
Adds a type summary for `Substring` values.
With this change, a summary string shows the substring slice. The substring's children show the base string, and start/end indexes.
```
(lldb) v substring
(Substring) substring = "bcdefghijklmnopqrstuvwxy" {
_slice = {
_startIndex = 1[utf8]
_endIndex = 25[utf8]
_base = "abcdefghijklmnopqrstuvwxyz"
}
}
```
Before this change, a literal substring was not shown, only the full base string:
```
(lldb) v substring
(Substring) substring = {
_slice = {
_startIndex = 1[utf8]
_endIndex = 25[utf8]
_base = "abcdefghijklmnopqrstuvwxyz"
}
}
```
#### Implementation Notes
This supports Swift native (utf8) strings. NSString (utf16) are not yet supported, that will be a follow up change. Additionally, this change requires that the indexes be matching encoding.
rdar://91431816
(cherry picked from commit a514263)
kastiglione
added a commit
that referenced
this pull request
Dec 3, 2022
kastiglione
added a commit
that referenced
this pull request
Feb 9, 2023
Adds a type summary for `Substring` values.
With this change, a summary string shows the substring slice. The substring's children show the base string, and start/end indexes.
```
(lldb) v substring
(Substring) substring = "bcdefghijklmnopqrstuvwxy" {
_slice = {
_startIndex = 1[utf8]
_endIndex = 25[utf8]
_base = "abcdefghijklmnopqrstuvwxyz"
}
}
```
Before this change, a literal substring was not shown, only the full base string:
```
(lldb) v substring
(Substring) substring = {
_slice = {
_startIndex = 1[utf8]
_endIndex = 25[utf8]
_base = "abcdefghijklmnopqrstuvwxyz"
}
}
```
#### Implementation Notes
This supports Swift native (utf8) strings. NSString (utf16) are not yet supported, that will be a follow up change. Additionally, this change requires that the indexes be matching encoding.
rdar://91431816
(cherry picked from commit a514263)
kastiglione
added a commit
that referenced
this pull request
Feb 9, 2023
Adds a type summary for `Substring` values.
With this change, a summary string shows the substring slice. The substring's children show the base string, and start/end indexes.
```
(lldb) v substring
(Substring) substring = "bcdefghijklmnopqrstuvwxy" {
_slice = {
_startIndex = 1[utf8]
_endIndex = 25[utf8]
_base = "abcdefghijklmnopqrstuvwxyz"
}
}
```
Before this change, a literal substring was not shown, only the full base string:
```
(lldb) v substring
(Substring) substring = {
_slice = {
_startIndex = 1[utf8]
_endIndex = 25[utf8]
_base = "abcdefghijklmnopqrstuvwxyz"
}
}
```
#### Implementation Notes
This supports Swift native (utf8) strings. NSString (utf16) are not yet supported, that will be a follow up change. Additionally, this change requires that the indexes be matching encoding.
rdar://91431816
(cherry picked from commit a514263)
kastiglione
added a commit
that referenced
this pull request
Feb 9, 2023
kastiglione
added a commit
that referenced
this pull request
Feb 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a type summary for
Substringvalues.With this change, a summary string shows the substring slice. The substring's children show the base string, and start/end indexes.
Before this change, a literal substring was not shown, only the full base string:
Implementation Notes
This supports Swift native (utf8) strings. NSString (utf16) are not yet supported, that will be a follow up change. Additionally, this change requires that the indexes be matching encoding.
rdar://91431816