[stable/20221013 Cherry Pick] [clang][deps] Remove unintentional move
#5590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix related to D135414. The original intention was to keep `BaseFS` as a member of the worker and conditionally overlay it with local in-memory FS. The `move` of ref-counted `BaseFS` was not intended, and it's a bug. Disabling parallelism in the "by-module-name" test reliably reproduces this, and the test itself doesn't *need* parallelism. (I think `-j 4` was cargo culted from another test.) Reusing that test to check for correct behavior... Reviewed By: DavidSpickett Differential Revision: https://reviews.llvm.org/D136124
|
rdar://102152282 |
|
@swift-ci test |
|
Is this necessary? I already have a PR up: #5568. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally fixed by @jansvoboda11 in https://reviews.llvm.org/D136124
This is a fix related to D135414. The original intention was to keep
BaseFSas a member of the worker and conditionally overlay it with local in-memory FS. Themoveof ref-countedBaseFSwas not intended, and it's a bug.Disabling parallelism in the "by-module-name" test reliably reproduces this, and the test itself doesn't need parallelism. (I think
-j 4was cargo culted from another test.) Reusing that test to check for correct behavior...Reviewed By: DavidSpickett
Differential Revision: https://reviews.llvm.org/D136124