[lldb] Allow "var" persistent variables to be modified #5651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unconditionally call `SwiftExpressionVariable::SetIsModifiable`, for both
`true` and `false`. Previously `SetIsModifiable(false)` was called for `let`
variables - now `var` variables will result in `SetIsModifiable(true)`.
This fixes the following bug:
(lldb) expr var $count = 123
(lldb) expr $count = 456
error: expression failed to parse:
error: <EXPR>:3:1: error: cannot assign to value: '$count' is immutable
$count = 456
^~
kastiglione
changed the title
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
augusto2112
approved these changes
Nov 28, 2022
adrian-prantl
approved these changes
Nov 28, 2022
kastiglione
deleted the
dl/lldb-allow-var-expr-variables-to-be-modified
branch
kastiglione
added a commit
that referenced
this pull request
Dec 3, 2022
Unconditionally call `SwiftExpressionVariable::SetIsModifiable`, for both `let` and `var` variables. Previously `SetIsModifiable(false)` was called for `let` variables - now `var` variables will result in `SetIsModifiable(true)`.
This fixes the following bug:
(lldb) expr var $count = 123
(lldb) expr $count = 456
error: expression failed to parse:
error: <EXPR>:3:1: error: cannot assign to value: '$count' is immutable
$count = 456
^~
rdar://102675900
(cherry picked from commit 6089eda)
kastiglione
added a commit
that referenced
this pull request
Feb 9, 2023
Unconditionally call `SwiftExpressionVariable::SetIsModifiable`, for both `let` and `var` variables. Previously `SetIsModifiable(false)` was called for `let` variables - now `var` variables will result in `SetIsModifiable(true)`.
This fixes the following bug:
(lldb) expr var $count = 123
(lldb) expr $count = 456
error: expression failed to parse:
error: <EXPR>:3:1: error: cannot assign to value: '$count' is immutable
$count = 456
^~
rdar://102675900
(cherry picked from commit 6089eda)
kastiglione
added a commit
that referenced
this pull request
Feb 9, 2023
Unconditionally call `SwiftExpressionVariable::SetIsModifiable`, for both `let` and `var` variables. Previously `SetIsModifiable(false)` was called for `let` variables - now `var` variables will result in `SetIsModifiable(true)`.
This fixes the following bug:
(lldb) expr var $count = 123
(lldb) expr $count = 456
error: expression failed to parse:
error: <EXPR>:3:1: error: cannot assign to value: '$count' is immutable
$count = 456
^~
rdar://102675900
(cherry picked from commit 6089eda)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unconditionally call
SwiftExpressionVariable::SetIsModifiable, for bothletandvarvariables. PreviouslySetIsModifiable(false)was called forletvariables - nowvarvariables will result inSetIsModifiable(true).This fixes the following bug:
rdar://102675900