Move deserialization of import search paths into the scratch context #5692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@dreampiggy This is functionally identical, but much more efficient implementation of #4203 |
|
test with swiftlang/swift#62345 |
adrian-prantl
force-pushed
the
40097459
branch
from
d9c2630 to
d2fd18d
Compare
|
test with swiftlang/swift#62345 |
kastiglione
reviewed
Dec 2, 2022
Import and framework search paths were previously not discovered by validateSerializedAST() so SwiftASTContextForExpressions had the various per-module SwiftASTContext load all registered Swift modules and then grabbed the discovered search paths from their respective deserialized CompilerInvocations. We now extended validateSerializedAST() to also deserialize the search paths, which allows getting rid of this last dependency between SwiftASTContextForExpressions and the per-module SwiftASTContexts. rdar://40097459
adrian-prantl
force-pushed
the
40097459
branch
from
d2fd18d to
0a4675b
Compare
|
test with swiftlang/swift#62345 |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import and framework search paths were previously not discovered by
validateSerializedAST() so SwiftASTContextForExpressions had the
various per-module SwiftASTContext load all registered Swift modules
and then grabbed the discovered search paths from their respective
deserialized CompilerInvocations. We now extended
validateSerializedAST() to also deserialize the search paths, which
allows getting rid of this last dependency between
SwiftASTContextForExpressions and the per-module SwiftASTContexts.
rdar://40097459