Parse: handle another case of invalid handling for attributes #5869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang would improperly disallow GNU attributes before C++ standard attributes when a declaration had a linkage specifier. Handle this similarly to the previous case of invalid parsing. We now better match the parsing rules from GCC.
|
CC: @bnbarham |
|
Thanks @compnerd! If we end up making any changes to this one upstream we should cherry-pick those as well. |
|
@swift-ci please test |
|
Failures were |
|
Same stdlib/FixedPointConversion tests failing elsewhere. I'm happy to merge this one @compnerd |
|
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang would improperly disallow GNU attributes before C++ standard attributes when a declaration had a linkage specifier. Handle this similarly to the previous case of invalid parsing. We now better match the parsing rules from GCC.