[Clang][driver][cc1] Fix handling of of C++20 modules in ObjectiveC++ #6134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, ObjectiveC++ does not currently support C++20 modules. This is because ObjectiveC requires Local Submodule Visibility in practice, which is not compatible with C++20 modules. Given our options are to either drop ObjectiveC compatibility, or C++20 modules compatibility, we currently choose to disable C++20 modules to allow using other C++20 features in ObjectiveC++20 mode. This patch also allows enabling LSV and C++20 modules in ObjectiveC++20 mode for the few cases it does work. It adds errors for incompatible configurations.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, ObjectiveC++ does not currently support C++20 modules. This is because ObjectiveC requires Local Submodule Visibility in practice, which is not compatible with C++20 modules. Given our options are to either drop ObjectiveC compatibility, or C++20 modules compatibility, we currently choose to disable C++20 modules to allow using other C++20 features in ObjectiveC++20 mode.
This patch also allows enabling LSV and C++20 modules in ObjectiveC++20 mode for the few cases it does work. It adds errors for incompatible configurations.
cherry-pick from next: #6015