Skip to content

Revert "Reland: Dead Virtual Function Elimination" #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2020
Merged

Revert "Reland: Dead Virtual Function Elimination" #615

merged 1 commit into from
Jan 23, 2020

Conversation

hyp
Copy link

@hyp hyp commented Jan 22, 2020

This reverts commit 3b598b9.

Conflicts:
llvm/lib/Transforms/IPO/GlobalDCE.cpp
llvm/test/ThinLTO/X86/lazyload_metadata.ll

@hyp
Revert "Reland: Dead Virtual Function Elimination"
0304533 
This reverts commit 3b598b9.

 Conflicts:
	llvm/lib/Transforms/IPO/GlobalDCE.cpp
	llvm/test/ThinLTO/X86/lazyload_metadata.ll
@hyp hyp requested a review from cachemeifyoucan January 22, 2020 00:39
@hyp
Copy link
Author

hyp commented Jan 22, 2020

@swift-ci please test

cachemeifyoucan
cachemeifyoucan approved these changes Jan 22, 2020
View reviewed changes
Copy link

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a workaround

@hyp hyp merged commit 15d75a0 into swiftlang:apple/stable/20200108 Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachemeifyoucan cachemeifyoucan cachemeifyoucan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @cachemeifyoucan