Skip to content

Revert "[Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic" #6299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2023
Merged

Revert "[Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic" #6299

merged 1 commit into from
Feb 17, 2023

Conversation

rsundahl
Copy link

This reverts commit be6b346. Unblocks CI until we can pick a complete fix

rdar://105483090
rdar://105442362

Revert "[Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic"
bda2fb0 
This reverts commit be6b346.
Unblocks CI until we can pick a complete fix

rdar://105483090
rdar://105442362
@rsundahl
Copy link
Author

I wasn't aware of @wrotki working on #6294 so spent the day bisecting until I got to this revert as a fix. Ultimately pulling the rest of upstream changes as #6294 does is probably the answer but this revert does the trick until then.

thetruestblue
thetruestblue approved these changes Feb 17, 2023
View reviewed changes
Copy link

@thetruestblue thetruestblue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is blocking CI. Please land this revert. Thanks for looking into this.

@rsundahl rsundahl merged commit c478370 into stable/20221013 Feb 17, 2023
@rsundahl rsundahl deleted the rsundahl/revertalloc64 branch February 17, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetruestblue thetruestblue thetruestblue approved these changes

@wrotki wrotki Awaiting requested review from wrotki

@yln yln Awaiting requested review from yln

@kubamracek kubamracek Awaiting requested review from kubamracek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsundahl @thetruestblue