Clang added a new feature to the ObjC compiler that will translate me… #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod calls to commonly un-overridden methods into a function that checks whether the method is overridden anywhere and if not directly dispatches to the NSObject implementation. That means if you do override any of these methods, "step-in" will not step into your code, since we hit the wrapper function, which has no debug info, and immediately step out again. Add code to recognize these functions as "trampolines" and a thread plan that will get us from the function to the user code, if overridden. <rdar://problem/54404114> Differential Revision: https://reviews.llvm.org/D73225
JDevlieghere
approved these changes
Jan 24, 2020
|
@swift-ci please test macos |
|
This should probably also go on |
|
Yes, that's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…thod
calls to commonly un-overridden methods into a function that checks whether
the method is overridden anywhere and if not directly dispatches to the
NSObject implementation.
That means if you do override any of these methods, "step-in" will not step
into your code, since we hit the wrapper function, which has no debug info,
and immediately step out again.
Add code to recognize these functions as "trampolines" and a thread plan that
will get us from the function to the user code, if overridden.
rdar://problem/54404114
Differential Revision: https://reviews.llvm.org/D73225