Eng/pr 58804805 58581965 20200108 #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a Class Sending a message to `self` when it is const and within a class method is safe because we know that `self` is the Class itself. We can only relax this warning in ARC. Signed-off-by: Pierre Habouzit <[email protected]> Radar-Id: rdar://problem/58581965 Differential Revision: https://reviews.llvm.org/D72747 (cherry picked from commit 7596d3c)
If we do, then the property_list_t length is wrong and class_getProperty gets very sad. Signed-off-by: Pierre Habouzit <[email protected]> Radar-Id: rdar://problem/58804805 Differential Revision: https://reviews.llvm.org/D73219 (cherry picked from commit 52311d0)
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.