[lldb] Lazily load Swift ASTContext in GetClangTypeNode #6629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
I have a new approach that's I'll take. |
|
Hopefully this PR will be superseded by swiftlang/swift#65082 |
|
Closing in favor of swiftlang/swift#65082 and #6634 |
kastiglione
deleted the
dl/lldb-lazily-load-swift-astcontext-in-getclangtypenode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessarily loading the Swift ASTContext from
GetClangTypeNode.This
Implvariable is used from MappedTypes.def, but the only places it's used are:This means most types do not need the AST Context, and loading it is unnecessary work.
This change lazily loads the AST Context, only when
getSwiftNameis called.