[lldb] Refactor IsTaggedPointer to use demangler #6637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
augusto2112
approved these changes
Apr 12, 2023
|
@swift-ci test |
adrian-prantl
approved these changes
Apr 13, 2023
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Outdated
Show resolved
Hide resolved
|
@swift-ci test Windows Platform |
|
@swift-ci test |
|
@swift-ci test |
adrian-prantl
approved these changes
Apr 14, 2023
|
@swift-ci test |
|
@swift-ci test Windows Platform |
kastiglione
deleted the
dl/lldb-refactor-istaggedpointer-to-use-demangler
branch
adrian-prantl
pushed a commit
to adrian-prantl/llvm-project
that referenced
this pull request
May 5, 2023
Use the demangled node tree inside `IsTaggedPointer` to avoid loading the Swift ASTContext for the type.
A demangled tree for an unowned reference is structured like so:
```
kind=Global
kind=TypeMangling
kind=Type
kind=Unowned
kind=Type
kind=Class
kind=Module, text="SomeModule"
kind=Identifier, text="TheClass"
```
rdar://107961993
(cherry picked from commit e7c8cd8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the demangled node tree inside
IsTaggedPointerto avoid loading the Swift ASTContext for the type.A demangled tree for an unowned reference is structured like so:
rdar://107961993