[lldb] Make use of target triple in TypeSystemSwiftTypeRef #6692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
| return module->GetArchitecture().GetTriple(); | ||
| else if (auto target_sp = GetTargetWP().lock()) | ||
| return target_sp->GetArchitecture().GetTriple(); | ||
| llvm_unreachable("Expected module or target"); |
There was a problem hiding this comment.
This should be reachable if you run type system queries without a target. There is nothing in the SBAPI that prevents someone from doing this, so we shouldn't crash. Maybe lldb_assert() or logging?
There was a problem hiding this comment.
thanks. It's now changed to a log.
| else | ||
| assert(false && "Expected module or target"); | ||
|
|
||
| llvm::Triple triple = GetTriple(); |
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
|
@adrian-prantl after removing this assert, is this good? |
adrian-prantl
approved these changes
Apr 25, 2023
kastiglione
deleted the
dl/lldb-make-use-of-target-triple-in-typesystemswifttyperef
branch
kastiglione
added a commit
that referenced
this pull request
May 5, 2023
Update `TypeSystemSwiftTypeRef::GetTriple` to make use of an available target. With this change, `GetNameImporter` can work in more cases, since it only needs a triple. And since `GetNameImporter` can be expected to return a `ClangNameImporter` instance, the fallback to using Swift ASTContexts can be removed. This eliminates another case of unnecessarily loading Swift ASTContexts, which incurs a one time overhead that should only be paid when required. Partial follow up to #6654 (cherry-picked from commit f097595)
kastiglione
added a commit
that referenced
this pull request
May 5, 2023
…6790) Update `TypeSystemSwiftTypeRef::GetTriple` to make use of an available target. With this change, `GetNameImporter` can work in more cases, since it only needs a triple. And since `GetNameImporter` can be expected to return a `ClangNameImporter` instance, the fallback to using Swift ASTContexts can be removed. This eliminates another case of unnecessarily loading Swift ASTContexts, which incurs a one time overhead that should only be paid when required. Partial follow up to #6654 (cherry-picked from commit f097595)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
TypeSystemSwiftTypeRef::GetTripleto make use of an available target.With this change,
GetNameImportercan work in more cases, since it only needs a triple. And sinceGetNameImportercan be expected to return aClangNameImporterinstance, the fallback to using Swift ASTContexts can be removed.This eliminates another case of unnecessarily loading Swift ASTContexts, which incurs a one time overhead that should only be paid when required.
Partial follow up to #6654