ObjectFile: correct Swift AST section name for PE/COFF #6705
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PE/COFF has a section name limit at 8 characters. To accommodate that we name the AST wrapping section `swiftast`. The ELF name (`.swift_ast`) was replicated here without adjustment which results in LLDB being unable to locate the modulewrap content. Match the behaviour of the compiler to allow LLDB to load the data.
|
@swift-ci please test |
|
(merging this as this is windows specific and tested locally as well in that it helps things) |
| @@ -1015,7 +1015,7 @@ SectionType ObjectFilePECOFF::GetSectionType(llvm::StringRef sect_name, | |||
| // .eh_frame can be truncated to 8 chars. | |||
| .Cases(".eh_frame", ".eh_fram", eSectionTypeEHFrame) | |||
| .Case(".gosymtab", eSectionTypeGoSymtab) | |||
| .Case(".swift_ast", eSectionTypeSwiftModules) // downstream change | |||
| .Case("swiftast", eSectionTypeSwiftModules) // downstream change | |||
There was a problem hiding this comment.
You may need to make this change in a couple more places, including the Swift repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PE/COFF has a section name limit at 8 characters. To accommodate that we name the AST wrapping section
swiftast. The ELF name (.swift_ast) was replicated here without adjustment which results in LLDB being unable to locate the modulewrap content. Match the behaviour of the compiler to allow LLDB to load the data.