Line table fix hack2 #6735
Closed
Line table fix hack2 #6735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the option -mllvm -cas-friendly-debug-info, we expect the line table to be emitted in such a way, that it is split-able in the CAS by every function's line table contribution. This was achieved by emitting a DW_LNE_end_sequence at the end of the function's contribution to the line table. This however, had some issues. Namely, there was an extra DW_LNE_end_sequence being emitted at the end of the line table. There was also the case where because of DW_LNE_end_sequence denoting a reset of the state machine, unnecessary DW_LNS_set_file directives were being emitted which was preventing deduplication. These issues have been addressed along with changes to associated tests.
rastogishubham
force-pushed
the
LineTableFixHack2
branch
from
cb53be0 to
95919b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hack to see why the line table fix in https://github.com/apple/llvm-project/pull/6718/files is causing a mild increase in cas size