Host: introduce GetSDKPath extension point for Windows
#6736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
I still think that it is a bit odd as we are saying "SDKPath" for Windows, except that is entirely unclear what that means - Windows SDK? Swift SDK? Oculus SDK? Something else? In any case, I've posted https://reviews.llvm.org/D149397 that we can decide if we want to go down that route. With the introduction of |
|
Partially completed in #6746. Once we get that merged, I can pull out the actual changes to support the SDK on Windows from this. Leaving this open until then. |
compnerd
force-pushed
the
sdkroot
branch
3 times, most recently
from
8ebae86 to
9b15210
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Introduce a new extension point to allow a host to specify a SDK path. On Windows, there is the default global SDK path which is identified by the `SDKROOT` environment variable. Wire this into the process to construct the proper search paths for the Swift module when debugging.
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
adrian-prantl
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new extension point to allow a host to specify a SDK path. On Windows, there is the default global SDK path which is identified by the
SDKROOTenvironment variable. Wire this into the process to construct the proper search paths for the Swift module when debugging.