TypeSystem: add a platform hook for library search path additions #6927
Conversation
|
@swift-ci please test |
|
This looks like a change that should be made upstream on llvm.org first. |
|
@adrian-prantl I don't see how this would be upstream first. It is in a Swift specific path. |
|
@swift-ci please test |
|
If it's Swift-specific, then the function name probably should have |
|
The idea itself looks fine to me. Although it is only used for swift, does it make sense to put it on llvm.org? The change itself doesn't seem explicitly related to swift even if it's only used for swift. What do you think? |
|
I didn't notice that the other ones did have I think that while this could be useful upstream someday, we currently have a single use of it in That said, I'd like to get this into the 5.9 release as this is the last piece needed for the REPL on Windows I believe. I can try to upstream it in parallel. |
Windows does not provide a library search path through a mechanism similar to `DT_RPATH` or `LC_RPATH`. Libraries are instead resolved via the environment variable `Path`. Add a hook to inject the default library search path into the repl instance. This is required to ensure that system libraries are available. With this, it is finally possible to run the REPL on Windows without any additional parameters.
|
@swift-ci please test |
|
Indeed, I'd love to have this being available in vanilla lldb. At some point we'll have Windows support and who knows what we'll end up needing. But in any case, no time pressure |
|
@swift-ci please test Windows platform |
|
@walter-erquinigo, thanks, then it sounds like it has some reason to be upstreamed. I'll create a separate version that we can upstream in parallel, and then we can switch this over on main and go with this for 5.9. WDYT @bulbazord and @adrian-prantl? It would be nice to have the REPL be nice to use for the 5.9 release. |
Windows does not provide a library search path through a mechanism similar to
DT_RPATHorLC_RPATH. Libraries are instead resolved via the environment variablePath. Add a hook to inject the default library search path into the repl instance. This is required to ensure that system libraries are available. With this, it is finally possible to run the REPL on Windows without any additional parameters.