Cp/109185291 strip unaddressable bits from pc sp fp 59 #6993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a failure where we somehow get an invalid register number being used to calculate the canonical frame address, and this ends up with lldb crashing with a null deref because it assumes that it is always able to find information about that register. This patch adds a check for a failure to get a register, and declares the frame invalid in that case, with some additional logging or an assert for debug builds. Differential Revision: https://reviews.llvm.org/D143232 rdar://104428038 (cherry picked from commit 701030c)
Some Darwin corefiles can have the pc/fp/sp/lr in the live register context signed with pointer authentication; this patch changes RegisterContextUnwind to strip those bits off of those values as we try to walk the stack. Differential Revision: https://reviews.llvm.org/D152861 rdar://109185291 (cherry picked from commit 0ce7037)
|
@swift-ci please test |
JDevlieghere
approved these changes
Jun 15, 2023
JDevlieghere
deleted the
cp/109185291-strip-unaddressable-bits-from-pc-sp-fp-59
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.