Skip to content

[lldb] Fix ApplyWorkingDir not properly handling . includes when working dir is . #7061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DavidGoldman
Copy link

Cherry-pick #7024 to Swift 5.9. This fixes an issue debugging iOS apps with modulemaps + implicit modules with Bazel (which uses -iquote. typically).

The proper behavior: The include should be preserved as . instead of the previous behavior where it became an empty string.

…s . (swiftlang#7024)

In such a case the include should be preserved as . instead of the previous behavior 
where it became an empty string.
@DavidGoldman DavidGoldman changed the title [lldb] Fix ApplyWorkingDir not properly handle . includes when working dir is . [lldb] Fix ApplyWorkingDir not properly handling . includes when working dir is . Jul 7, 2023
@DavidGoldman
Copy link
Author

@swift-ci please test

@kastiglione kastiglione requested a review from JDevlieghere July 7, 2023 18:59
@DavidGoldman
Copy link
Author

@swift-ci please test

@JDevlieghere
Copy link

@swift-ci please test windows

@DavidGoldman
Copy link
Author

Can someone merge this for me? Thanks!

@JDevlieghere JDevlieghere merged commit 009faee into swiftlang:swift/release/5.9 Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants