[lldb] Iterate over a snapshot of the modules to be added in SetupRef… #7091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
adrian-prantl
approved these changes
Jul 19, 2023
adrian-prantl
requested changes
Jul 20, 2023
| @@ -522,12 +529,11 @@ void SwiftLanguageRuntimeImpl::SetupReflection() { | |||
|
|
|||
There was a problem hiding this comment.
m_modules_to_add has been cleared when you reach the Progress initializer. I think you want the snapshot here?
…lection SwiftLanguageRuntimeImpl::SetupReflection is potentially recursive. To guard against any potential problems of iterating over the modules to be added list and mutating it at the same time, create a snapshot of said list and iterate over that instead. rdar://108767207
augusto2112
force-pushed
the
snapshot-setup-refl
branch
from
a75a77f to
10a9e64
Compare
|
@swift-ci test |
|
@swift-ci test windows |
adrian-prantl
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lection
SwiftLanguageRuntimeImpl::SetupReflection is potentially recursive. To guard against any potential problems of iterating over the modules to be added list and mutating it at the same time, create a snapshot of said list and iterate over that instead.
rdar://108767207