Cherry-pick some lldb changes to stable/20230725 #7124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does a few related things: - Removes unused function `uuid_is_null` - Removes unneeded includes of UuidCompatibility.h - Renames UuidCompatibility to AppleUuidCompatibility and adds a comment to clarify intent of header. - Moves AppleUuidCompatibility to the include directory Differential Revision: https://reviews.llvm.org/D156562 (cherry picked from commit db9087a)
In a809720 I refactored some logic to deal with the clang resource directory in standalone LLDB builds. However, this logic escaped me because it only runs when you do not build LLDB.framework. Differential Revision: https://reviews.llvm.org/D156763 (cherry picked from commit 6888de1)
I noticed these were missing. Differential Revision: https://reviews.llvm.org/D156764 (cherry picked from commit b8aba26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all the patches I've landed upstream since the branch. I'll need these in the future, so cherry-picking them now when it's low-risk and low-effort seems like the reasonable thing to do.