Skip to content

[lldb] Use correct log API inSwiftLanguageRuntimeDynamicTypeResolution (NFC) #7134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link

@kastiglione kastiglione commented Aug 2, 2023

No description provided.

@kastiglione kastiglione force-pushed the dl/lldb-Use-correct-log-API-inSwiftLanguageRuntimeDynamicTypeResolution-NFC branch from 5e82804 to 655a3fd Compare August 2, 2023 22:52
@kastiglione
Copy link
Author

This can go in now, or later, either is fine.

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test windows

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly good, though if we could convert this to LLDB_LOG, and skip the string conversions that would be even nicer!

@adrian-prantl adrian-prantl merged commit 46ac717 into swift/release/5.9 Aug 24, 2023
@kastiglione kastiglione deleted the dl/lldb-Use-correct-log-API-inSwiftLanguageRuntimeDynamicTypeResolution-NFC branch August 24, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants