When ProcessMachCore has metadata for a binary, don't scan #7203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mach-O corefiles have several possible types of metadata for the binaries that were running when the corefile was written. ProcessMachCore will try to find these binaries, and load them. When we have a hint, but could not find the binary, this change makes ProcessMachCore not fall back to scanning the corefile looking for ANY binary that it could load. We sometimes have multiple binaries present in the memory in a corefile, but only the correct binary should be loaded, the others are data. Differential Revision: https://reviews.llvm.org/D157168 rdar://112602508 (cherry picked from commit c5f8110)
|
@swift-ci please test |
jasonmolenda
deleted the
eng/r112602508-dont-scan-corefile-for-binary-if-metadata-failed-to-find-it
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ProcessMachCore has metadata for a binary, don't scan
Mach-O corefiles have several possible types of metadata for the binaries that were running when the corefile was written. ProcessMachCore will try to find these binaries, and load them. When we have a hint, but could not find the binary, this change makes ProcessMachCore not fall back to scanning the corefile looking for ANY binary that it could load. We sometimes have multiple binaries present in the memory in a corefile, but only the correct binary should be loaded, the others are data.
Differential Revision: https://reviews.llvm.org/D157168 rdar://112602508
(cherry picked from commit c5f8110)