Add "process metadata" Mach-O LC_NOTE for corefiles #7450
Merged
+418
−294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new LC_NOTE for Mach-O corefiles, "proces metadata", which is a JSON string. Currently there may be a `threads` key in the JSON, and if `threads` is present, it is an array with the same number of elements as there are LC_THREADs in the corefile. This patch adds support for a `thread_id` key-value for each `thread` entry, to supply a thread ID for that LC_THREAD. Differential Revision: https://reviews.llvm.org/D158785 rdar://113037252 (cherry picked from commit 2cab996)
|
@swift-ci please test |
JDevlieghere
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "process metadata" Mach-O LC_NOTE for corefiles
Add a new LC_NOTE for Mach-O corefiles, "proces metadata", which is a JSON string. Currently there may be a
threadskey in the JSON, and ifthreadsis present, it is an array with the same number of elements as there are LC_THREADs in the corefile. This patch adds support for athread_idkey-value for eachthreadentry, to supply a thread ID for that LC_THREAD.Differential Revision: https://reviews.llvm.org/D158785 rdar://113037252
(cherry picked from commit 2cab996)