[lldb/Target] Fix frame recognizer list crash when registered with nullptr
#749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nullptr One way to register a recognizer is to use RegularExpressionSP for the module and symbol. In order to match a symbol regardless of the module, the recognizer can be registered with a nullptr for the module. However, this cause the frame recognizer list command to crash because it calls RegularExpression::GetText without checking if the shared pointer is valid. This patch adds checks for the symbol and module RegularExpressionSP. Differential Revision: https://reviews.llvm.org/D74212 Signed-off-by: Med Ismail Bennani <[email protected]>
…l recognizers (NFC) By clearing the recognizers before starting the test, we ensure that the recognizers that get initialized when lldb starts won't alter the expected results of this test (i.e. recognizer index). Signed-off-by: Med Ismail Bennani <[email protected]>
This patch skips the AssertFrameRecognizer test for Linux since it appears to fail on certain distributions (AFAIK Fedora & ArchLinux). The failure happen because the thread don't set the current frame to the most relevant one. So the stopped location doesn't match with what the test is expecting. The test will be enabled again after I'll be able to reproduce the failure on one of those platform and fix the issue. Signed-off-by: Med Ismail Bennani <[email protected]>
|
@swift-ci Please test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[lldb/Target] Fix
frame recognizer listcrash when registered with nullptrOne way to register a recognizer is to use RegularExpressionSP for the
module and symbol.
In order to match a symbol regardless of the module, the recognizer can
be registered with a nullptr for the module. However, this cause the
frame recognizer list command to crash because it calls
RegularExpression::GetText without checking if the shared pointer is valid.
This patch adds checks for the symbol and module RegularExpressionSP.
Differential Revision: https://reviews.llvm.org/D74212