[lldb][Target] Refactor Target::FindLoadAddr #7544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Target::FindLoadAddrForNameInSymbolsAndPersistentVariables` has been split into `Target::FindLoadAddrForNameInSymbols` and `Target::FindLoadAddrForNameInPersistentVariables`. Instead of performing both searches in one function, `Target::FindLoadAddrForNameInSymbolsAndPersistentVariables` will call its constituent functions. This allows `SwiftLanguageRuntime::FindSymbolForSwiftObject` to look for symbols with `Target::FindLoadAddrForNameInSymbols` instead of performing this search on its own. rdar://32228544
|
This looks like generic code, should this target llvm.org rather than the Swift fork? |
|
|
This reverts commit 2542856. Remove `Target::FindLoadAddrForNameInSymbolsAndPersistentVariables` as this is going unused in the codebase. As such the implementation being used in `FindSymbolForSwiftObject` is reverted to its original version.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target::FindLoadAddrForNameInSymbolsAndPersistentVariableshas been split intoTarget::FindLoadAddrForNameInSymbolsandTarget::FindLoadAddrForNameInPersistentVariables. Instead of performing both searches in one function,Target::FindLoadAddrForNameInSymbolsAndPersistentVariableswill call its constituent functions.This allows
SwiftLanguageRuntime::FindSymbolForSwiftObjectto look for symbols withTarget::FindLoadAddrForNameInSymbolsinstead of performing this search on its own.rdar://32228544