Skip to content

[Clang][ObjC] Add optionality to property attribute strings. #7568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

al45tair
Copy link

@al45tair al45tair commented Oct 4, 2023

Add a new attribute, "?", to the property attribute string for properties of protocols that are declared @optional.

(Previously https://reviews.llvm.org/D135273)

rdar://100463542

Add a new attribute, "?", to the property attribute string for
properties of protocols that are declared @optional.

(Previously https://reviews.llvm.org/D135273)

rdar://100463524
@al45tair al45tair requested a review from mikeash October 4, 2023 07:31
@al45tair
Copy link
Author

al45tair commented Oct 4, 2023

This is a cherry pick of llvm#66507.

@al45tair
Copy link
Author

al45tair commented Oct 4, 2023

@swift-ci Please smoke test

@al45tair
Copy link
Author

al45tair commented Oct 4, 2023

@swift-ci Please smoke test Linux platform

@al45tair
Copy link
Author

al45tair commented Oct 4, 2023

@swift-ci Please smoke test macOS platform

@al45tair
Copy link
Author

@swift-ci Please smoke test

@shahmishal
Copy link
Member

@swift-ci test

@al45tair al45tair merged commit 2ab914d into swiftlang:swift/release/5.10 Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants