[cherry-pick stable/20230725] [Modules] Add a flag to control builtin headers being in system modules #7618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… headers being in system modules Differential Revision: https://reviews.llvm.org/D159483 rdar://105819340
Visibility isn't in stable/20230725, move CC1Option to Flags.
… expression and loading modules rdar://105819340
|
@swift-ci test |
kateinoigakukun
added a commit
to kateinoigakukun/swift
that referenced
this pull request
Oct 23, 2023
stable/20230725 now rejects including builtin headers in modulemap by default to avoid module cycles on non-Apple platforms. Builtin headers are now part of their own `_Builtin_XXX` modules. See: - swiftlang/llvm-project#7618 - https://reviews.llvm.org/D159483 - https://reviews.llvm.org/D159064
kateinoigakukun
added a commit
to kateinoigakukun/swift
that referenced
this pull request
Oct 24, 2023
stable/20230725 now rejects including builtin headers in modulemap by default to avoid module cycles on non-Apple platforms. Builtin headers are now part of their own `_Builtin_XXX` modules. See: - swiftlang/llvm-project#7618 - https://reviews.llvm.org/D159483 - https://reviews.llvm.org/D159064
ian-twilightcoder
added a commit
to ian-twilightcoder/llvm-project
that referenced
this pull request
Oct 26, 2023
ian-twilightcoder
added a commit
that referenced
this pull request
Oct 26, 2023
Revert "Merge pull request #7618 from ian-twilightcoder/builtin-flag"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://reviews.llvm.org/D159483
rdar://105819340