Don't update the triple when loading additional dylibs in the expression evaluator #7633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
requested review from
kastiglione,
JDevlieghere and
augusto2112
|
@swift-ci test |
JDevlieghere
approved these changes
Oct 16, 2023
augusto2112
approved these changes
Oct 16, 2023
The variable was removed in https://reviews.llvm.org/D85539
…ion evaluator This is a surgical fix for the 5.9 branch to address a design problem. When a new Swift module is imported in the expression evaluator, LLDB deserialized the compiler invocation from it and the way the code was written it replaced the existing compiler invocation instead of just adding additional search paths. This patch fixes this by adding a paths-only mode that uses a temporary compiler invocation object. rdar://115747362
adrian-prantl
force-pushed
the
115747362-5.9
branch
from
2e4ac04 to
88cc67d
Compare
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a surgical fix for the 5.9 branch to address a design
problem. When a new Swift module is imported in the expression
evaluator, LLDB deserialized the compiler invocation from it and the
way the code was written it replaced the existing compiler invocation
instead of just adding additional search paths. This patch fixes this
by adding a paths-only mode that uses a temporary compiler invocation
object.
rdar://115747362