[lldb] Add Foundation._NSSwiftTimeZone support #7657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
| ConstString("timeZone"), | ||
| ConstString("_timeZone"), | ||
| ConstString("some"), | ||
| ConstString("identifier"), |
There was a problem hiding this comment.
This almost looks like some leftover debugging code?
There was a problem hiding this comment.
It's not debugging code. That's the variable path that contains the time zone's name (effectively timeZone._timeZone.identifier).
There was a problem hiding this comment.
Oh right .some is the enumerator for Optional!
"some identifier" just sounded like a placeholder :-)
`_NSSwiftTimeZone` is the new Swift implementation of `NSTimeZone`. (cherry picked from commit 666003e)
kastiglione
force-pushed
the
lldb-Add-Foundation._NSSwiftTimeZone-support
branch
from
8e6b4a0 to
11ecea5
Compare
|
@swift-ci test |
adrian-prantl
approved these changes
Oct 23, 2023
|
Can you cherry-pick this to 5.9 and 5.10? |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick the two missing commits from #7074.