Skip to content

Cherry pick GetTypeForDIE changes #7667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

augusto2112
Copy link

No description provided.

(cherry picked from commit 040c4f4)
(cherry picked from commit fd6891f75c7692a6baab6b25bb70860530ac2088)
The "protected" was accidentally removed during refactoring of
SymbolFileDWARF. Reintroduce it and also make DWARFASTParser a friend
class since 040c4f4 was merged and
won't build without it, as it dependeds on a method which was made
public by accident.

(cherry picked from commit db9023e)
When moving the GetTypeForDIE function from DWARFASTParserClang to
DWARFASTParser, I kept the signature as-is. To match the rest of the
function signatures in DWARFASTParser, remove the full name
(lldb_private::plugin::dwarf::DWARFDIE -> DWARFDIE) in the signature
of DWARFASTParser::GetTypeForDIE.

(cherry picked from commit 3c6b7d0)
@augusto2112
Copy link
Author

@swift-ci test

@augusto2112 augusto2112 merged commit bc20919 into swiftlang:stable/20230725 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant