Skip to content

Fix compilation error with clang-10 #7685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

adrian-prantl
Copy link

No description provided.

@adrian-prantl
Copy link
Author

@swift-ci test llvm

@rastogishubham
Copy link

It seems that @etcwilde has one of these issues fixed in #7676

Copy link

@rastogishubham rastogishubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please look at comment about @etcwilde 's PR

Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like I missed one of the missing std::move's from the llvm-cas tool.

@adrian-prantl
Copy link
Author

@swift-ci test llvm

@etcwilde
Copy link
Member

etcwilde commented Nov 1, 2023

#7676 already merged. This change should be a no-op if you rebase now.

@adrian-prantl
Copy link
Author

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants