Skip to content

[clang][deps] Fix __has_include behavior with umbrella headers #7687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2023
Merged

[clang][deps] Fix __has_include behavior with umbrella headers #7687

merged 2 commits into from
Oct 30, 2023

Conversation

jansvoboda11
Copy link

@jansvoboda11 jansvoboda11 commented Oct 25, 2023 •
edited
Loading

rdar://116926060

@jansvoboda11 jansvoboda11 changed the title [clang][deps] Fix __has_include behavior with umbrella headers" with include-tree [clang][deps] Fix __has_include behavior with umbrella headers" with include-tree Oct 25, 2023
@jansvoboda11
Copy link
Author

@swift-ci please test

@jansvoboda11 jansvoboda11 changed the title [clang][deps] Fix __has_include behavior with umbrella headers" with include-tree [clang][deps] Fix __has_include behavior with umbrella headers Oct 25, 2023
@jansvoboda11
[clang][deps] Fix __has_include behavior with umbrella headers (llv…
fb04985 
…m#70144)

Previously, Clang wouldn't try to resolve the module for the header
being checked via `__has_include`. This meant that such header was
considered textual (a.k.a. part of the module Clang is currently
compiling).

rdar://116926060
(cherry picked from commit a1b4238)
@jansvoboda11
[clang][deps] Test "Fix __has_include behavior with umbrella header…
8c81edb 
…s" with include-tree (#7672)
@jansvoboda11 jansvoboda11 force-pushed the jan_svoboda/20230725-had-include-cherry-pick branch from f61a2f3 to 8c81edb Compare October 26, 2023 16:24
@jansvoboda11
Copy link
Author

@swift-ci please test

@jansvoboda11
Copy link
Author

@swift-ci please test windows platform

@jansvoboda11
Copy link
Author

swiftlang/swift#69441
@swift-ci please test macos platform

@jansvoboda11 jansvoboda11 merged commit afaa1cc into stable/20230725 Oct 30, 2023
@jansvoboda11 jansvoboda11 deleted the jan_svoboda/20230725-had-include-cherry-pick branch October 30, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jansvoboda11